os-issue-tracker icon indicating copy to clipboard operation
os-issue-tracker copied to clipboard

Default spell checker marks words followed by a period as incorrectly spelled in app text fields

Open jorgeluiscarrillo opened this issue 3 years ago • 28 comments

IMG_20211026_141018 Keyboard doesn't seem to matter. Tested with both AOSP keyboard and FlorisBoard. Seems to only occur in app text fields with auto-correction for example, AOSP Messaging or Element. The word with the period included can be added to the dictionary and it won't be marked as incorrect anymore.

jorgeluiscarrillo avatar Oct 26 '21 21:10 jorgeluiscarrillo

I have the same issue as well (Pixel 4a - 5G SP1A.210812.015.2021102613) but if I try to add it to the dictionary, the word is still marked as misspelled. I only use the GrapheneOS keyboard.

oldmanonthebus avatar Nov 04 '21 19:11 oldmanonthebus

This problem appeared just a few days ago for me while it was first reported here 12 days ago. I'm using OS version 2021102300 SP1A.210812.015.2021102300 on a Pixel 4a.

If you double-tap after the word to end the sentence, two spaces get inserted and the word isn't flagged as a spelling mistake.

ezeeman avatar Nov 07 '21 20:11 ezeeman

I've been seeing this on Android 12 Pixel 5a too.

nep2ner avatar Nov 10 '21 10:11 nep2ner

I've had the same issue since Android 12


Specification: os: 2021110617 phone: Pixel 5

JanOstrowka avatar Nov 11 '21 21:11 JanOstrowka

Checking in, confirming the issue. Still present with 2021112404 on Pixel 4a.

cautious-bread avatar Dec 08 '21 06:12 cautious-bread

Not enough information is being provided such as the language and keyboard configuration.

thestinger avatar Dec 08 '21 07:12 thestinger

Sorry about that. In my particular case it's happening with any keyboard I use. AnySoft, OpenBoard, the default one. Language is English GB.

I've personally tried removing all keyboards, resting/emptying dictionaries, all sorts.

My wife has the same phone and is seeing the same issue. Her device is completely "stock" GrapheneOS except for the Signal and DuckDuckGo browser apps.

Is there anything we can be doing to help resolve the issue? My next stage was to completey reflash my device with GrapheneOS and start again. But I'd really rather not.

I'm assuming you're unable to reproduce it yourself?

cautious-bread avatar Dec 08 '21 11:12 cautious-bread

Build number: SP1A.211105.004.2021112404. This has been updated since my original report here on Nov 7 and the problem persists.

From Settings | System | Languages & input:

  • Languages: English (United States)
  • On-screen keyboard: GrapheneOS Keyboard
  • Physical keyboard: Not connected
  • Spell checker: GrapheneOS Spell Checker

ezeeman avatar Dec 08 '21 18:12 ezeeman

This happens for me as well on my Pixel 6, build *2021122018

  • Language: English (US)
  • On-screen keyboards: GrapheneOS Keyboard, and GBoard
  • Spell checker: GrapheneOS Spell Checker

dailyherold avatar Dec 29 '21 04:12 dailyherold

I may have found a fix! I went to Settings > System > Languages and Input > Spell Checker . Under Default Spell Checker I selected a different option from one of the installed keyboards, tested typing, then selected the GrapheneOS Spell Checker again.

No more incorrect red underlines!

It looks like whatever is causing the problem becomes "unstuck" when changing the Spell Checker chosen.

Have a go and report back please.

cautious-bread avatar Jan 27 '22 06:01 cautious-bread

Ah poo. I was premature in my excitement. All other spell checkers are fine - once I tested a text box in another app the GrapheneOS Spell Checker still has the same problem. If I select the Spell Checker of another keyboard the problem goes away.

So close.

cautious-bread avatar Jan 27 '22 06:01 cautious-bread

So it appears to depend on the spell checker. I downloaded a few keyboards to test...

  • GrapheneOS = incorrect red underlines with a manual period.
  • OpenBoard = incorrect red underlines with a manual period.
  • FlorisBoard = no underlines at all. But I think this is a Floris thing.
  • Gboard (hey, I had to know) = Works fine. Red underlines for spelling errors only.

I'd like to use the default GrapheneOS Spell Checker so will continue to poke about to see if my limited abilities can find something to get someone's teeth into.

cautious-bread avatar Jan 27 '22 07:01 cautious-bread

I found that if you double space (2 X space key) at the end it auto adds the period without the underline. I don't know why this is.

On Thu, Jan 27, 2022 at 7:07 AM greenerk @.***> wrote:

So it appears to depend on the spell checker. I downloaded a few keyboards to test...

  • GrapheneOS = incorrect red underlines with a manual period.
  • OpenBoard = incorrect red underlines with a manual period.
  • FlorisBoard = no underlines at all. But I think this is a Floris thing.
  • Gboard (hey, I had to know) = Works fine. Red underlines for spelling errors only.

I'd like to use the default GrapheneOS Spell Checker so will continue to poke about to see if my limited abilities can find something to get someone's teeth into.

— Reply to this email directly, view it on GitHub https://github.com/GrapheneOS/os-issue-tracker/issues/758#issuecomment-1022909176, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJS236DLBTJRAUO4PWOMPRTUYDVKXANCNFSM5GYZW3WA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you commented.Message ID: @.***>

oldmanonthebus avatar Jan 28 '22 01:01 oldmanonthebus

This is standard for almost all keyboards with autocorrect now. They have an option for "auto punctuation" to add in a period when double tapping the space button. Nothing to do with the bug this ticket is for.

Screenshot_20220128-062027_1

cautious-bread avatar Jan 28 '22 06:01 cautious-bread

@greenerk It's related to the issue. They're pointing out that entering a space via double spacing does not produce the red underline bug.

nep2ner avatar Jan 28 '22 07:01 nep2ner

Ah, fair enough. It was also mentioned my ezeeman in an earlier comment.

cautious-bread avatar Jan 28 '22 08:01 cautious-bread

Chiming in here - I have tried troubleshooting to no avail and toyed around with FlorisBoard.

I did notice that although it underlines words with a full stop (period) that has been manually entered, if you click the back arrow to go out to your Messages listing and then back into the draft message, the red lines disappear?! Unfortunately this includes blatantly misspelt words with or without the period, mind you.

Currently on Pixel 4a build number: SQ1A.220105.002.2022011423

From Settings | System | Languages & input: Languages: English (UK) On-screen keyboard: GrapheneOS Keyboard Physical keyboard: Not connected Spell checker: GrapheneOS Spell Checker

Look forward to seeing how this ends up! Keep up the great work Devs :)

tsaoi avatar Jan 31 '22 05:01 tsaoi

Does anyone know if this is a wider issue with AOSP higher upstream or specific to GrapheneOS? I have other devices I toy with, running other non-stock ROMs and GrapheneOS is the only one exhibiting this issue. I'm surprised there aren't more users chiming in as I assumed it would be affecting all users. Edit: this isn't a complaint, I'm genuinely just curious.

cautious-bread avatar Apr 08 '22 17:04 cautious-bread

It's an AOSP keyboard issue. We aren't applying a workaround for the issue since it causes system_server crashes. We need to switch to a different keyboard.

thestinger avatar Apr 09 '22 02:04 thestinger

As this is an AOSP issue, does that mean that everyone will be experiencing this, or just this select few of us? I want to reflash my phone fresh again (to see if that clears it), but not if the issue will remain.

cautious-bread avatar May 05 '22 15:05 cautious-bread

Let us know if this is still an issue in Android 13.

thestinger avatar Aug 31 '22 08:08 thestinger

Afraid so. Auto-punctuation appears to be OK, it's when you enter a full-stop/period manually that the false red line gets triggered.

signal-2022-08-31-095459

I recently flashed a couple of other non-Pixel devices with Android 12 versions of LineageOS and /e/ ROMs, and the issue appeared on those too. I'm surprised the wider Android community aren't screaming from the rooftops about it - do so many people just "not notice"?

cautious-bread avatar Aug 31 '22 09:08 cautious-bread

Could it be locale-dependent? My primary language is set to "English (Australia)" and similarly in the AOSP keyboard settings. Spell checker is set to "Use system languages".

This is LineageOS, I hasten to add...

mbg-unsw avatar Aug 31 '22 09:08 mbg-unsw

Interesting thought. I've just played about with the language settings - Although mine is set to "English (UK)" the American spellings of words are not highlighted as incorrect, but I'd expect them to be.

cautious-bread avatar Aug 31 '22 10:08 cautious-bread

Still a problem on android 13 with GrapheneOS keyboard.

Not a problem with Gboard.

ezeeman avatar Aug 31 '22 15:08 ezeeman

Not a problem with Gboard.

I'm getting it on all keyboards now.

cautious-bread avatar Aug 31 '22 15:08 cautious-bread

After trying a bunch of combinations on both the phone's language and the keyboards, I get the same error everytime. Only tried using Graphene's keyboard.

On Wed, Aug 31, 2022 at 9:56 AM Malcolm Gillies @.***> wrote:

Could it be locale-dependent? My primary language is set to "English (Australia)" and similarly in the AOSP keyboard settings. Spell checker is set to "Use system languages".

— Reply to this email directly, view it on GitHub https://github.com/GrapheneOS/os-issue-tracker/issues/758#issuecomment-1232725647, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJS236BAWKGV62SW3ZGYG2DV34T3ZANCNFSM5GYZW3WA . You are receiving this because you commented.Message ID: @.***>

oldmanonthebus avatar Aug 31 '22 21:08 oldmanonthebus

Afraid so. Auto-punctuation appears to be OK, it's when you enter a full-stop/period manually that the false red line gets triggered.

signal-2022-08-31-095459

I recently flashed a couple of other non-Pixel devices with Android 12 versions of LineageOS and /e/ ROMs, and the issue appeared on those too. I'm surprised the wider Android community aren't screaming from the rooftops about it - do so many people just "not notice"?

Oh we notice. Pixel 5a on android 13, US English, GrapheneOS stock keyboard. The incorrect underlines still pop up when double spacing after a word, and also when manually placing a period through the keyboard and then spacing away from it.

Injectionation avatar Sep 02 '22 16:09 Injectionation