os-issue-tracker icon indicating copy to clipboard operation
os-issue-tracker copied to clipboard
verified publisher icon GrapheneOS

Allow enabling mobile hotspot with data saver on

Open Lppsoeht opened this issue 1 year ago • 1 comments

Low priority, but there are certain circumstances where the user needs to enable the hotspot(some apps for example) but he still wants apps to treat the networking as data saver is still on. Enabling the hotspot has nothing to do with using lots of cellular data. It's an inconvenience having to disable and reenable data saver on and on.

Lppsoeht avatar Oct 16 '24 19:10 Lppsoeht

I have a PR for this: https://github.com/GrapheneOS/platform_packages_apps_Settings/pull/308

Since I cannot test it in the emulator I'll need to get a spare Pixel to test.

neelchauhan avatar Dec 09 '24 22:12 neelchauhan

This seems fine. It's strange that it disables it.

thestinger avatar Dec 09 '24 22:12 thestinger

The issue wasn't the emulator, but instead I removed a line of code which was critical. I reinstated the code.

Please review my https://github.com/GrapheneOS/platform_packages_apps_Settings/pull/308 when you can.

neelchauhan avatar Dec 10 '24 00:12 neelchauhan

The good news is this PR works, but the bad news is that there are still UI bugs:

  • The statusbar gets stuck on "data saver on" even when this option is on

I'll add another PR for the statusbar.

Video: https://youtu.be/NlHA_toPIc4

neelchauhan avatar Dec 12 '24 18:12 neelchauhan