Vanadium icon indicating copy to clipboard operation
Vanadium copied to clipboard

provide dictionary downloads via GrapheneOS server or bundle them

Open thestinger opened this issue 4 years ago • 5 comments

thestinger avatar Nov 28 '20 08:11 thestinger

What dictionary are these? Wondering if it is covered in Bromite or needs a patch also there.

csagan5 avatar Nov 28 '20 09:11 csagan5

You've disabled updating the list of available dictionaries but I still think it will attempt (and fail, due to domain replacement) to obtain the dictionaries from the gvt1 redirector URL.

https://github.com/bromite/bromite/blob/master/build/patches/translate-disable-fetching-of-translate-languages-from-server.patch

thestinger avatar Nov 28 '20 09:11 thestinger

i.e. go to languages and add a language

thestinger avatar Nov 28 '20 09:11 thestinger

https://github.com/chromium/chromium/blob/301d265e779c792a4e050dbdd795e24eb46158d9/chrome/browser/spellchecker/spellcheck_hunspell_dictionary.cc#L259

thestinger avatar Nov 28 '20 09:11 thestinger

I just tested with Wireshark, I see no requests made when adding a language. I wonder how this is supposed to work.

csagan5 avatar Nov 28 '20 11:11 csagan5