Vanadium icon indicating copy to clipboard operation
Vanadium copied to clipboard

Brave Search not getting detected

Open ProgrammerWhoPrograms opened this issue 1 year ago • 2 comments

Not showing up in the selection list after use whereas Mojeek and Etymonline do.

Maybe this is why?

I think there are a couple upstream bugs that prevent the OpenSearch detection from working properly; you can see this because Firefox detects more search engine sites than Chromium derivatives.

I have fixed them in this Bromite patch: https://github.com/bromite/bromite/blob/100.0.4896.135/build/patches/OpenSearch-miscellaneous.patch and added more verbose logging to help understand what happens.

The bugs are:

  • last visited time is a 0 UNIX timestamp first time the search engine is detected, thus it is never displayed on the recent engines list
  • upon new visits to the search engine the logic to add it is skipped if the search engine was already parsed in the past, but the visit time is not updated

ProgrammerWhoPrograms avatar Jan 03 '24 14:01 ProgrammerWhoPrograms

same for Startpage, tried GET and POST parameters and searched using the engine

secretmango avatar Jan 15 '24 17:01 secretmango

Hello, I just wanted to contribute to the discussion, as Brave was recognized correctly in my case. I did a Brave search in the normal tab without any custom settings and was then able to select Brave in the search engine settings. With Startpage it did not work for me even after switching to GET requests, I always call it up with !s searchquery if necessary.

heuwerk avatar Feb 02 '24 07:02 heuwerk