GrapheneOS
Improve image resolution in quality optimization mode
Explicitly requests the resolution selector to choose the highest resolution when the user selects "Quality" in "Optimize for" setting in the quick settings dialog
Fixes the issue described in #532
The PR should fix the issue described in #523 too unless the vendor itself isn't exposing the resolution for third party apps to use
The PR should fix the issue described in #523 too unless the vendor itself isn't exposing the resolution for third party apps to use
Regarding the issue you mentioned... well, I don't reckon that's the case for me, see. Cause with that debug APK you sent over, the one that's meant to sort it, there isn't an option for me to switch between the 12MB and 50MB camera resolution. So, yeah, that's just how it is for me. I'm not sure if it'll be the same for everyone else, though.
Hi @fesowowako
Thanks for reaching out!
The debug apk we sent you had the highest resolution enabled by default. While it would be good to have the highest possible resolution on every device, it could lead to unexpectedly higher image sizes which the user might not always want.
In the latest changes made to this PR, we have included an option to go with the highest resolution irrespective of the capture rate that might allow the user to go with the highest resolution supported by their device (50MP or what it could be for their device). This would allow them to take pictures of their desired resolution, solving the issue for them. Explicitly choosing a resolution would be a different issue, there's a separate PR for that #505
@MHShetty Alright, didn't realise that. Ta for telling me. Hoping this update gets put live soon so I can use all the good bits without that annoying message every time I open the app.
@thestinger Is this pull request ever going to be pushed to the main branch, then? Apologies for the question, but I am just being curious, yeah? And I hope this gets pushed soon, when possible, as it fixes my issue. So yeah, and sorry once again if that annoys you, asking what the estimated time for it being pushed is.
I was hoping this feature will be included in the next release. Not sure why it wasn't
Hi @PavelGloba,
There are currently multiple PRs that we want to merge together so we're separating them into different releases and waiting for while to ensure that we're able to smoothly ensure that everything works well while merging these PRs. This PR and its corresponding issue should get updated once these changes get merged.
Thanks a lot for your valuable time and patience!