Apps icon indicating copy to clipboard operation
Apps copied to clipboard

Published 20 hours ago • verified publisher icon GrapheneOS

Replace Glide with Coil

Open t895 opened this issue 10 months ago • 8 comments

Closes #352

t895 avatar Apr 13 '24 21:04 t895

What's the impact on release APK size?

muhomorr avatar Apr 18 '24 08:04 muhomorr

2.7 megabytes commit 262277c 2.8 megabytes this PR

topminipie avatar Apr 18 '24 18:04 topminipie

@topminipie Is right. I just ran a couple builds and got these results for APK size. main - 2759KBs coil - 2895KBs

t895 avatar Apr 18 '24 22:04 t895

What are the advantages of switching to Coil?

muhomorr avatar Apr 19 '24 05:04 muhomorr

I generally prefer to use Coil in my Android apps nowadays because of the Kotlin-first syntax. Working with it in the Dolphin, Citra, and yuzu Android apps has been very plesant whether it be for loading images with the built-in options or creating custom loaders for the job.

As for performance or special features, I don't know of any advantages Coil has over Glide.

t895 avatar Apr 19 '24 15:04 t895

It sounds like Coil is a nicer library, but we're just unsure if we want to move when it increases app size slightly without really offering any advantages for us. We'll need to think about it.

thestinger avatar Apr 19 '24 16:04 thestinger

Glide is still maintained. If it wasn't, it would be an easy decision to replace an unmaintained library.

thestinger avatar Apr 19 '24 16:04 thestinger

That's fair I'll just leave this open if you ever become interested in it

t895 avatar Apr 19 '24 16:04 t895