graphql-postgres-subscriptions icon indicating copy to clipboard operation
graphql-postgres-subscriptions copied to clipboard
verified publisher icon GraphQLCollege

Deprecated dependency

Open opravil-jan opened this issue 6 years ago • 4 comments

Hi Guys,

is it possible to update dependency graphql-subscriptions up to version 1.0.0?

Thanks

opravil-jan avatar Jun 10 '19 17:06 opravil-jan

I forked this repo and replaced pg-ipc with pg-listen So now it will retry the connection to postgres.

Also update deps.

https://github.com/originlabs/graphql-postgres-subscriptions

Published to npm as @originlabs/graphql-postgres-subscriptions-retry

Jonahss avatar Mar 20 '21 00:03 Jonahss

@jonahss Thanks for sharing the repo! Since Issues are not available on your repo fork I thought I'd try to reach you here. I wanted to share that the github link on the NPM page goes to the original graphql-postgres-subscriptions github and not your @originlabs/graphql-postgres-subscriptions-retry github repo.

Also was wondering if you had any plans to add typescript definitions for it? If not, I make take a stab at it.

cmidgley avatar Mar 23 '21 17:03 cmidgley

Oh! I'm not used to issues not being enabled by default. Added them, thanks.

@cmidgley Typescript definitions would be very welcome!

I think you can use the type already defined for this class: https://github.com/apollographql/graphql-subscriptions/blob/master/src/pubsub-engine.ts

Jonahss avatar Mar 24 '21 00:03 Jonahss

@cmidgley I just published a new patch version, fixing a major bug where once one connection was killed, no new notifications came in 🤦

Jonahss avatar Mar 31 '21 00:03 Jonahss