mjml icon indicating copy to clipboard operation
mjml copied to clipboard

Fix wrong const cmdPanel

Open Enc3phale opened this issue 4 years ago • 3 comments

Q A
Bug fix? Y
New feature? N
Automated tests included? N
Related user documentation PR URL N
Related developer documentation PR URL N
Issues addressed (#s or URLs) N
BC breaks? N
Deprecations? N

Description:

Undo and Redo buttons are set in the wrong panel due to an error in this const : const cmdPanel = pnm.getPanel('options');

With this correction, it's like https://github.com/artf/grapesjs-preset-newsletter

Enc3phale avatar Mar 11 '20 16:03 Enc3phale

In Newsletter undo & redo buttons are within commands panel: https://github.com/artf/grapesjs-preset-newsletter/blob/master/src/buttons.js#L40

Enc3phale avatar Jul 17 '20 07:07 Enc3phale

Ok I'll take a look once I release v0.1.16

DRoet avatar Jul 17 '20 08:07 DRoet

Have you tested this locally? this commit seems to break the undo/redo buttons on the latest version

DRoet avatar Jul 17 '20 20:07 DRoet

With the latest release this is not an issue anymore

artf avatar Oct 01 '22 12:10 artf