mjml icon indicating copy to clipboard operation
mjml copied to clipboard

Social group mode (vertical/horizontal) doesn't change in editor

Open viniciiusds opened this issue 5 years ago • 3 comments

I tested the vertical mode of the social group in my project and the demo as well and the same problem occurs when selecting the vertical mode, it doesn't change in the editor. But after converting to HTML the vertical mode works. Thanks.

Screen Shot 2019-09-05 at 17 29 16

viniciiusds avatar Sep 05 '19 20:09 viniciiusds

The issue is that the style attributes are hardcoded into to view with

view: {
			...coreMjmlView,
			tagName: 'table',
			attributes: {
				style: 'pointer-events: all; float: none; display: inline-table;',
			},

As you can see display: inline-table and the floar properties are set in the view, regardless of the orientation set on the Social component.

Actually the settings (Horizontal/Vertical) is passed to the Social MJML component correctly and it is, in fact, rendering horizontal and Vertical as it should, but we are just missing sending the style properties to the SocialElement component.

@artf how do we do that?

kickbk avatar Sep 05 '19 21:09 kickbk

@artf any update on this? I also faced the same issue.

NorthstarTech avatar Nov 19 '19 12:11 NorthstarTech

@kickbk @viniciiusds Did you guys find the solution for this issue? @artf What's the alternate solution for this issue? Help Needed

NorthstarTech avatar Apr 20 '20 20:04 NorthstarTech