mjml
mjml copied to clipboard
GrapesJS
Added Carousel (WIP)
@artf Some mj-carousel styles only appear when it has children. What do you think is the best way to get these styles during mj-carousel rendering?
@artf Some mj-carousel styles only appear when it has children. What do you think is the best way to get these styles during mj-carousel rendering?
In init of the Model, we can set up a listener on components() and update the stylable property based on children basis, what do you think?
ps: huge thanks for the PR ❤️
Dang I literally added this component for my company a week ago. I have a working version of this.
https://s3.amazonaws.com/springbot_www_development/okrealcarouseldemo.gif
I also updated the component since I made that gif above so that you can use asset manager to upload the arrow icons instead of pasting in a URL, as well as adding in ability to select custom arrow icons from a set drop down menu.
We also noticed that there are some limitations on the carousel. For example, on version 3.x of MJML, you can't have multiple carousels at once, or it doesn't render correctly. So we ended up adding in some validation to disable adding of multiple carousels on the component:add listener. The arrow icons also have some serious compatibility issues, and it doesn't work on some of the most commonly used email clients like Gmail. The email recipients are limited to using the thumbnail images to flip through the images.
I'd be willing to open up a a new PR with my version of the carousel if you like what you see :)
Big fan of your work btw Artur, keep it up!
Still working on this btw, I built mine on MJML v3.5 and now it's a bit different on v4.x :sweat_smile:
I was having lots of issues while trying to do this since my carousel was built on a different version of MJML. Then I got busy with other things and I'm not working on this anymore.
If someone else can take over, then that would be amazing :)
Is this still being worked on?
Sorry but unfortunately I'm busy with other projects too.
Closing due to inactivity, this branch also needs a lot of rebase work after the v1.0 release