grapesjs icon indicating copy to clipboard operation
grapesjs copied to clipboard

BUG: Too much recursion

Open jlafosse opened this issue 1 year ago • 0 comments
trafficstars

GrapesJS version

  • [X] I confirm to use the latest version of GrapesJS

What browser are you using?

Firefox 131.0.2

Reproducible demo link

https://grapesjs.com/demo-newsletter-editor.html

Describe the bug

How to reproduce the bug?

  1. Go to the grapesjs demo, then import the following html:
<div class="foobar">
    <img data-gjs-locked="true" width="500" src="https://cdn.pixabay.com/photo/2021/12/16/15/26/forest-6874717_1280.jpg">
</div>
  1. Open your browser console.
  2. Rapidly click on the image multiple times.

What is the expected behavior? Should work without errors.

What is the current behavior? This causes a recursion error in FireFox. Chrome does not seem to be affected by this issue. I am testing this on OSX 13.6.9 and I have included a short screen recording.

Uncaught InternalError: too much recursion
    getList Component.ts:1931
    ensureInList Component.ts:1866
    ensureInList Component.ts:1880
    Ke Underscore
    Backbone Backbone
    ensureInList Component.ts:1880
    ensureInList Component.ts:1880
    Ke Underscore
    Backbone Backbone
    ensureInList Component.ts:1880
    ensureInList Component.ts:1880

My suspicion is that the issue is coming from the following function: https://github.com/GrapesJS/grapesjs/blob/dev/packages/core/src/dom_components/model/Components.ts#L373

Thanks.

https://github.com/user-attachments/assets/54b6c40f-d435-41f9-a09f-47450f01523e

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

jlafosse avatar Oct 11 '24 15:10 jlafosse