jsCalendar icon indicating copy to clipboard operation
jsCalendar copied to clipboard

Integrated a year picker

Open zangarmarsh opened this issue 3 years ago • 9 comments

The year picker is accessible by clicking onto the month name. Maybe it would worth add an option to create it conditionally.

zangarmarsh avatar May 18 '21 16:05 zangarmarsh

We have to make some changes so that it does not affect themes and that it is contained inside the layout of the calendar. Maybe I have to help you port this to an extension.

GramThanos avatar May 20 '21 17:05 GramThanos

Hello @GramThanos . As you wish. I thought it would be a fundamental feature that needed to be integrated in the core library since it's great to have the chance to pick the year from a calendar. If you'd rather port this as extension it's ok; otherwise, feel free to fix it to resolve collisions with themes. Let me know.

zangarmarsh avatar May 21 '21 07:05 zangarmarsh

I don't know :P Maybe you are right. I will have a look at it and give it some thought.

On Fri, May 21, 2021, 10:33 AM zangarmarsh @.***> wrote:

Hello @GramThanos https://github.com/GramThanos . As you wish. I thought it would be a good and fundamental feature that needed to be integrated in the core library. If you think it's better to port this as extension it's ok; otherwise, feel free to fix it to resolve collisions with themes.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/GramThanos/jsCalendar/pull/59#issuecomment-845728959, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADRLVT4Q276NWPYKGIPSNDLTOYEDVANCNFSM45C4655Q .

GramThanos avatar May 21 '21 09:05 GramThanos

Hi, I found this great component not long ago and have integrated it into my Apache Royale projects. I would be very interested to know if the "year selection" is going to be integrated (maybe it is already integrated and I didn't know how to use it). Have you thought about doing the same with the months?

Thank you. Hiedra.

mjesteve avatar Aug 17 '21 18:08 mjesteve

Hey, I will look into that and come back to you.

GramThanos avatar Aug 18 '21 11:08 GramThanos

Thank you very much for your attention. I really like jscalendar, I was able to create a Medium Theme without any problem: sizes, colours,... that's very important for me as my goal is to make it look completely integrated in Royale. I'm going to open an issue to ask the community about a problem I have, maybe someone with more experience than me with js can guide me to solve it.

I'll be attentive to your comments.

Thanks again. Hiedra

mjesteve avatar Aug 18 '21 12:08 mjesteve

Any news on it?

Neustradamus avatar Nov 02 '22 19:11 Neustradamus

I have neglected this project. I do plan to update it, but not right now. Hopefully on the next version release I will also create a guide for the extension API thus all the updates could be added as an extension.

GramThanos avatar Nov 02 '22 20:11 GramThanos

I will be watching :)

mjesteve avatar Nov 03 '22 00:11 mjesteve