wrapt icon indicating copy to clipboard operation
wrapt copied to clipboard

Published 20 hours ago • verified publisher icon GrahamDumpleton

Drop support for Python < 3.6

Open tiran opened this issue 3 years ago • 5 comments

Signed-off-by: Christian Heimes [email protected]

tiran avatar Oct 06 '21 12:10 tiran

Why wouldn't I skip this and go straight to:

  • https://github.com/GrahamDumpleton/wrapt/pull/187

GrahamDumpleton avatar Oct 06 '21 20:10 GrahamDumpleton

This PR is pretty much safe, does not introduce any nasty C bugs, and removes all Python 2 related quirks.

PR #187 doesn't remove all Python 2 code. There is also a possibility that it introduces C bugs or ref leaks. It needs a thorough review.

tiran avatar Oct 06 '21 21:10 tiran

Such PR essentially removing this amount of compatibility boilerplate and still passing the test suite for python 3.6-3.10 and pypy can only be approved! Looks Very Good To Me.

I also vouch to integrate this separately from #187 for the sake of the VCS sanity.

n1ngu avatar Oct 15 '21 16:10 n1ngu

Taking a look at this, and testing against Python 3.11a6, wrapt fails to install on Python 3.11 due to setuptools.formatargspec being removed. However, since this PR drops support for Python 3.5 and lower, it should be replaced with setuptools.signature as recommended in the release notes for Python 3.11

zevaryx avatar Mar 10 '22 22:03 zevaryx

Version 1.14.0 of wrapt deals with Python 3.11 changes. This PR would need to be rebased against that.

GrahamDumpleton avatar Mar 10 '22 22:03 GrahamDumpleton