mod_wsgi icon indicating copy to clipboard operation
mod_wsgi copied to clipboard

Fix ability to build with Apapche 2.2.

Open bdc34 opened this issue 3 years ago • 2 comments

Graham, Here is one additional change to compile with Apache 2.2. I was out on vacation, sorry to not get it to you sooner.

bdc34 avatar Sep 14 '22 22:09 bdc34

What was the original error message? Was it compile time error or a run time crash?

The AP_MODULE_MAGIC_AT_LEAST mechanism is only meant to be used in relation to quite specific change sets in history and not a general mechanism to choose between Apache 2.2 or 2.4.

GrahamDumpleton avatar Sep 14 '22 23:09 GrahamDumpleton

The compile time warning was: src/server/mod_wsgi.c:12921:9: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast] d = (core_dir_config *)ap_get_core_module_config(r->per_dir_config); ^

I looked up in httpd/include/ap_mmn.h when ap_get_core_module_config was introduced and used that magic number.

bdc34 avatar Sep 14 '22 23:09 bdc34

If possible can you check the develop branch. I changed the conditional check to enable code for all Apache 2.4 versions rather than have a specific change set check.

GrahamDumpleton avatar Oct 05 '22 06:10 GrahamDumpleton