Graham Dumpleton

Results 765 comments of Graham Dumpleton

I may not have implemented the modulo conversion because it only works for C extension. There doesn't appear to be a way to have it work for pure Python code....

Use of proxy for modulo doesn't even work in all cases when using C API either. Current thinking is that for nb_power case, shouldn't even unwrap the second argument, let...

Will have to look at it when have time. Overriding ``__getattribute__()`` in the proxy object in wrapt itself is not practical as it dramatically affects performance doing that. Have you...

The ``error()`` wrapper function is actually being called, so somewhere in the implementation of the attribute lookup mechanism of Python, it is interpreting any exception raised in the property method...

Run: ``` pip uninstall wrapt WRAPT_EXTENSIONS=false pip install wrapt ``` IOW, when installing the module set the environment variable ``WRAPT_EXTENSIONS`` to ``false``.

Would have to know where you are proposing the change be made. There are use cases for wrapt module proxy objects whereby users will create a class which derives from...

I already use the partial wrapper approach to break out ``__call__()`` as it caused similar issues early on. Trying to create even more variations and the combinations will get messy,...

Overriding ``__getattribute__()`` is too expensive as impacts every attribute lookup and not just missing ones. Am not sure if overriding ``__getattr__()`` will have desired effect on a C implementation as...

If one assumes that the only things one should pickle from the proxy are the special '_self_' prefixed attributes, since anything else is meant to be proxied through to the...

You may even be able to avoid `__setstate__()` if in `__reduce__()` the third argument is supplied as a `dict`. ``` dict(filter(lambda _: _[0].startswith('_self_'), vars(a).items())) ```