Gradience icon indicating copy to clipboard operation
Gradience copied to clipboard

bug: Top-Left Corner Of LibAdwaita apps are still using Default Theme

Open heinthanth opened this issue 2 years ago • 11 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues

What happened?

Using Gradience Nightly, I applied Presets. And navigation-sidebar color is correct now. But top-left corner of navigation-sidebar is still using default theme. I also attached a screenshot. Thanks! I really love this application.

To Reproduce

  1. Open Gradience
  2. Load presets ( which is different from default Adwaita theme )
  3. Click Apply
  4. Logout/Login or Restart ( I tried restart )
  5. Open nautilus or gnome-control-center or contact apps, etc.
  6. Observe the top-left corner

Expected behavior

Top-left corner also utilize the customized color setting.

Screenshots

image

OS

Arch Linux

DE/WM version

GNOME 45.0, Mutter

Version

0.3.1.r2.ge5dd5c9-1

Installation method

AUR

Enabled system extensions (GNOME specific)

$ gnome-extensions list --enabled

[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]
[email protected]

Additional context

No response

Code of Conduct

  • [X] I agree to follow this project's Code of Conduct

heinthanth avatar Oct 12 '23 06:10 heinthanth

Welcome on Gradience. 🥳 We really appreciate your contribution. The core team will review your issue as soon as possible. You can also join the Matrix room: https://matrix.to/#/#Gradience-space:envs.net or the Discord server: https://discord.com/invite/4njFDtfGEZ

github-actions[bot] avatar Oct 12 '23 06:10 github-actions[bot]

image

Background color of Nautilus picker also wrong.

heinthanth avatar Oct 12 '23 06:10 heinthanth

I think the fix of #815 does not fix all the issues (for both gtk4 libadwaita .config/gtk-4.0/gtk.css and gtk3 adw-gtk3 .config/gtk-3.0/gtk.css):

.navigation-sidebar {
	background-color: rgb(36, 39, 58);
}

This class does not include all of the sidebar (as you could probably tell from the previous screenshots).

The fix might be to use these variables: sidebar_bg_color, sidebar_fg_color, sidebar_border_color, sidebar_backdrop_color, sidebar_shade_color and remove the navigation-sidebar class.

For exemple on my side, I use this gtk.css for GTK4 and this gtk.css for GTK3 adw-gtk3. As you can see those variables are just copies of their equivalent header_* variables. (so sidebar_bg_color is simply header_bg_color).

For GTK4, it works fine.

image

However there is still an issue in my GTK3's gtk.css. When hovering the sidebar with the cursor, the highlight color is not shown. But overall it works well enough :

image

hydroxycarbamide avatar Oct 12 '23 11:10 hydroxycarbamide

Thanks @Hydroxycarbamide, For now, I added those custom variables in Custom css box for both GTK 4 and 3. And it works well!

@define-color sidebar_bg_color @window_bg_color;
@define-color sidebar_fg_color @window_fg_color;
@define-color sidebar_border_color @window_bg_color;
@define-color sidebar_backdrop_color @window_bg_color;

heinthanth avatar Oct 12 '23 12:10 heinthanth

This New vars are included in the latest version of gradience not yet released

0xMRTT avatar Oct 12 '23 20:10 0xMRTT

Thanks @Hydroxycarbamide, For now, I added those custom variables in Custom css box for both GTK 4 and 3. And it works well!

@define-color sidebar_bg_color @window_bg_color;
@define-color sidebar_fg_color @window_fg_color;
@define-color sidebar_border_color @window_bg_color;
@define-color sidebar_backdrop_color @window_bg_color;

Thanks for sharing this solution Dude. Works like a charm in my Gnome. Thanks a \o/!

thiagolucio avatar Nov 28 '23 12:11 thiagolucio

@Hydroxycarbamide Fix resolved the issue with the gradience theme not being applied to the top left of nautilus. However, there is a dark thin line dividing the files hamburger menu and the navigation/path/query/view/close section. Any ideas?

[arch]
adw-gtk-theme
gradience-git
libadwaita-without-adwaita-git
nautilus

keilmillerjr avatar Feb 07 '24 16:02 keilmillerjr

@Hydroxycarbamide Fix resolved the issue with the gradience preset not being applied to the top left of nautilus. However, there is a dark thin line dividing the files hamburger menu and the navigation/path/query/view/close section. Any ideas?

2024-02-07T12:07:43,652662862-05:00

[arch]
adw-gtk-theme
gradience-git
libadwaita-without-adwaita-git
nautilus

keilmillerjr avatar Feb 07 '24 17:02 keilmillerjr

It's probably a headerbar or a sidebar shade color

daudix avatar Feb 07 '24 17:02 daudix

I'm not sure if this is related, but for me with the official Catppuccin Mocha theme the sidebar of Libadwaita applications such as Nautilus is broken, with the top left issue and badly coloured text.

image

xynydev avatar Feb 11 '24 14:02 xynydev

I'm not sure if this is related, but for me with the official Catppuccin Mocha theme the sidebar of Libadwaita applications such as Nautilus is broken, with the top left issue and badly coloured text.

image

Yes. See the temporary fix.

keilmillerjr avatar Feb 16 '24 00:02 keilmillerjr