Irakli Gozalishvili
Irakli Gozalishvili
I'm realizing now that interface here is intentionally non-destructive, as in I could compute digest over and over. Unfortunately [node crypto APIs are destructive though](https://nodejs.org/api/crypto.html#hashdigestencoding) > The Hash object can...
For what it's worth Rust Multihash hasher has a [similar interface to one proposed here](https://github.com/multiformats/rust-multihash/blob/master/derive/src/hasher.rs) ```rs /// Trait implemented by a hash function implementation. pub trait Hasher { /// Consume...
> "I have some encoders, squish them together so I have one thing please" and having to chain `.or()` is going to lead to the typical `reduce()` pattern to make...
I think I'll make few more changes to this pr specifically: 1. Get rid of `.composed` getter this introduces. 2. Introduce `fromTable` function that take care of composing things. 3....
> (question from triage) @Gozala would it be less disruptive if we update the interface instead? I’m not sure how would you do that without going and changing an implementation...
> I think having the old module still in use makes the intended style of use less clear so probably best to avoid it? I think general functionality of tagging...
I'm realizing now that above proposed API is not great and pretty much will never be sync because CIDs need to be computed in order to build a DAG. I...
> @Gozala I'm not quite following you on the last comment there; is it the order that's a problem? I get that that sync API is a problem, but beyond...
> Did you just leave off the Promise return That was an accident, I didn’t mean to change return type > and name for brevity We can keep `name` field,...
> Could we work on the naming a bit? "Case" is a bit too out of place for a JS/TS code isn't it and is likely to be something that...