AusweisApp icon indicating copy to clipboard operation
AusweisApp copied to clipboard

CI build by github actions

Open chcg opened this issue 2 years ago • 16 comments

Please comment what is of interest from your point of view, so I could modify the PR to the relevant once (comment out or remove). Just used release builds. For debug builds also the ctests are running but for no target they are completely working and therefore not added here.

CI builds of desktop versions (against prebuild QT packages):

  • windows msvc x64
  • linux gcc x64 (QT apt package is just 6.2.4 on ubuntu 22.04, installed additionally 6.7.1 (as 6.7.2 is not yet available) via GH action)
  • macos clang (installation failure for QT 6.7.x) CI builds of smartphone versions:
  • linux android (NOK, cmake config issue, not added to workflow)
  • macos ios (NOK, cmake config issue, not added to workflow)

CI builds of openssl, qt libs + ausweisapp with this libs:

  • windows msvc x64
  • linux gcc x64
  • macos clang CI builds of smartphone versions:
  • linux android (just libs as there are config issues with the app)
  • macos ios (just libs as there are config issues with the app)

chcg avatar Mar 12 '23 09:03 chcg

Thanks! Did it work on your pipeline? I see 6 failing checks here. :-)

misery avatar Mar 22 '23 15:03 misery

@misery As written above the builds which are mentioned as NOK (Not OK) also fail on my side. I would consider this PR as a starting point if this is of interest and start with adding the working once and further work on the failing ones.

chcg avatar Mar 23 '23 22:03 chcg

What do you think about commenting the currently not working ones, then pull this in and have a separate PR for each of the failing ones?

Currently there are none of those CI builds, so the ones that work are already much better than nothing and concentrating on enabling a single one is likely more productive, too.

GitMensch avatar Jul 27 '23 07:07 GitMensch

I will add any working action. :-) So strip out the non-working actions into another pull request.

misery avatar Sep 25 '23 13:09 misery

Thanks for the update. Two failing actions left, which miss some qt6 dependencies and should afterwards pass.

GitMensch avatar Sep 30 '23 12:09 GitMensch

@GitMensch These two failing jobs where already running previously but now the package 'libclang-dev' is version 14 from apt which differs from the libclang package already installed within the docker container (https://github.com/actions/runner-images/blob/main/images/linux/Ubuntu2204-Readme.md 13.0.1 and 14) found by cmake which is still version 13.

chcg avatar Oct 01 '23 08:10 chcg

So sudo apt update and all is fine?

GitMensch avatar Oct 01 '23 08:10 GitMensch

@misery Adapted the workflow configs to run just the working ones. Additionally fixed the CodeQl action by using now apt QT 6.5.3 installation.

chcg avatar Nov 12 '23 08:11 chcg

@GovernikusAusweisApp2 @misery Please review / merge.

GitMensch avatar Nov 12 '23 09:11 GitMensch

Did you try to use ccache with github action caching? That should speed up the builds a lot.

misery avatar Jan 23 '24 13:01 misery

Did you try to use ccache with github action caching? That should speed up the builds a lot.

I haven't tested that. As builds are currently just occasionally I think the build time is not as crucial as for projects with plenty commits/PRs a day.

chcg avatar Jan 24 '24 19:01 chcg

first thanks for the docker container. Very usefull for end2end testing. Are you aware of issues with docker tag latest aka 2.1.0?

We noticed that our CI builds are failing with SAML checks with 2.1.0, but with 2.0.0 they work

hypery2k avatar Apr 09 '24 16:04 hypery2k

first thanks for the docker container. Very usefull for end2end testing. Are you aware of issues with docker tag latest aka 2.1.0?

We noticed that our CI builds are failing with SAML checks with 2.1.0, but with 2.0.0 they work

Do you mean the official Container SDK? If you have an issue please report this to [email protected].

misery avatar Apr 10 '24 08:04 misery

no, we using the docker image for verifying our login process for the identity card.

hypery2k avatar Apr 10 '24 09:04 hypery2k

no, we using the docker image for verifying our login process for the identity card.

If you mean this: https://hub.docker.com/r/governikus/ausweisapp2 ... please report to the mail address above.

misery avatar Apr 10 '24 09:04 misery

FYI: With latest 2.1.1 docker image it's working again

hypery2k avatar Apr 17 '24 06:04 hypery2k