ui-components icon indicating copy to clipboard operation
ui-components copied to clipboard

fix(#2089): visual fix for interactive states on input

Open twjeffery opened this issue 1 year ago • 0 comments

This is to fix this bug: https://github.com/GovAlta/ui-components/issues/2089

Before (the change)

image

The visual appearance of the error state on form fields is not consistent between Figma and Code components:

  • Red border is 2px vs. 3px.
  • Red border is set to Inside vs. Outside.
  • Fields with leading /trailing content have no red border around prefix/suffix vs. border around entire field plus thicker border around input field.
  • hover on default inputs (without trailing/leading content) hover border is outside - should be inside
  • should have no hover state on focus
  • should have no hover state on error
  • should not show borders around leading and trailing content

After (the change)

image image image image image
  • Hover border is interior --goa-border-width-m
  • Error border is interior --goa-border-width-m
  • Interactive border is exterior --goa-border-width-l
  • Error state has no hover state
  • Interactive state has no hover state
  • goa variables used everywhere applicable
  • leading and trailing content has no border, only input

twjeffery avatar Sep 24 '24 18:09 twjeffery