GovAlta
fix(#1438): update app header and microsite header padding
- Update padding for microsite header
- Make sure alignment between the microsite header and app header exists.
Demo link: https://vanessatran-ddi.github.io/ui-components/#/
Video:
https://github.com/GovAlta/ui-components/assets/120135417/11361ab7-6af9-4df6-b1ef-ea2136632044
@vanessatran-ddi A few issues have been found:
- [x] Small Screen size -- Padding right side AppHeader -- should be using the variable
--goa-spacing-m, it's using 1rem right now - [x] Medium Screen size -- Padding right side AppHeader -- should be using the variable
--goa-spacing-xl, it's using the same size as Small - [x] Large Screen size -- Padding right side AppHeader -- completely wrong, there's no padding at all
All of the above problems I noticed are because, unlike the Microsite Header which applies padding to the whole element, for the AppHeader, we're applying padding to elements inside the AppHeader, which feels strange and wrong.
@vanessatran-ddi A few issues have been found:
- [x] Small Screen size -- Padding right side AppHeader -- should be using the variable
--goa-spacing-m, it's using 1rem right now- [x] Medium Screen size -- Padding right side AppHeader -- should be using the variable
--goa-spacing-xl, it's using the same size as Small- [x] Large Screen size -- Padding right side AppHeader -- completely wrong, there's no padding at all
All of the above problems I noticed are because, unlike the Microsite Header which applies padding to the whole element, for the AppHeader, we're applying padding to elements inside the AppHeader, which feels strange and wrong.
Small screen:
Medium screen (Ipad Air)
Desktop
:tada: This PR is included in version 1.17.0-alpha.49 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 4.17.0-alpha.25 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 1.21.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 4.21.0 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 3.0.0-alpha.4 :tada:
The release is available on:
Your semantic-release bot :package::rocket:
:tada: This PR is included in version 3.0.3 :tada:
The release is available on:
Your semantic-release bot :package::rocket: