Georgia Zoi Leng comments

Results 22 comments of


                                            Georgia Zoi Leng

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

ah linting. will fix.

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

hi @ericyz The GHA trigger looks like it doesn't run on edits only on open of PR, so the lint will stay pending I suspect. Local run of ```make docker_test_lint```...

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

@apeabody thanks for running the tests. Can you pass on the fail? I don't have perms to see the CB fail. I tried to see if I can get a...

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

ah hold on more stuff was merged to main, just saw https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/commit/d6cb39062cc6ecc2f86af463afd883d1fd780657#diff-faa9a5d0f5012bcd444bd14cbfcc6a27cfa3f57619a29ebcb127472787b0036b let me update my branch and address this stuff in the mean time :)

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

@apeabody cheers for running again. Red again although I can't see why, I've updated this branch with yesterday's merge to master. What's the fail? is it due to my branch...

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

@apeabody are you able to share what is failing in the CB job? I'm unable to reproduce failure with existing tests. Have updated with latest from main.

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

> > @apeabody are you able to share what is failing in the CB job? I'm unable to reproduce failure with existing tests. Have updated with latest from main. >...

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

@apeabody can we run again? :) did the issue resolve re the retries?

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

oh man we had a green one last time. so close. updating again... :)

fix: firewall rules for autopilot clusters are ineffective. add cluster_network_tag to autopilot cluster network_tags if firewalls are toggled on

@apeabody can we run tests again :)