Zongle Wang

Results 554 comments of Zongle Wang

Any link about this issue? Please paste it in the comment.

Please file a bug to Google or find the existing one. We have to check if this is a bug or a feature, consider migrating the logic here for the...

Seems the `gradle/com/android/build` things are ignored by my global .gitignore rules.

Thanks for the report! Fixed in - #9 - https://github.com/Goooler/agp-sources/pull/12

`Persistent*` extends `Immutable*`, these extensions work for both of them.

Seems we can return `Persistent*` as the value, WHYT?

I didn't take `immutable*Of` as the implementation due to the deprecations, they are not suggested to be used. https://github.com/Kotlin/kotlinx.collections.immutable/blob/1d18389e32e8afdbf5caa89808fb5af308fb5c8d/core/commonMain/src/extensions.kt#L513-L570

This could be closed for now. It's covered by https://github.com/cashapp/licensee/blob/dca297b954b8a7eba622ad577686de6d0912aa1c/src/main/resources/app/cash/licensee/licenses.json#L520 https://github.com/cashapp/licensee/releases/tag/1.14.0

I added a new flag to control the shadowed variant in https://github.com/GradleUp/shadow/pull/1662.