Zongle Wang comments

Results 555 comments of


                                            Zongle Wang

Set up GitHub Actions and fix wrapper script

https://github.com/features/actions

Set up GitHub Actions and fix wrapper script

That makes sure the assemble tasks pass, and we can upload the build artifacts as well.

Documentation says `destinationDir` which has been changed for `destinationDirectory`

Thanks for this report! Addressing the fix in #876.

Zip entry actions

I believe this is outdated, and we shouldn't apply actions for Zip entries.

Support `$` prefix for private/non-importable classes.

I tested the pattern ```groovy relocate('com.google.common', 'com.my.internal.\\$guava\\$') ``` for the example from https://github.com/immutables/maven-shade-plugin#1-relocation-with--uglyfication The `com.google.common.Main` will be relocated to `com.my.internal.$guava$.Main`. See #1729.

Support `$` prefix for private/non-importable classes.

I tried to address this in #1729. Ideally, there should be an extra flag in `SimpleRelocator` to control this feature. However, since this is such an edge case, implementing it...

use embedded-kotlin to build plugins

I'm addressing a new fix to #66.

Legacy plugin application order breaks shadow detection logic updated for new id

CC @ljacomet

Unable to transform file with multiple transformers

The first zip entry is closed, but the second is not, and they share the same path but different values. I don't think we need to handle this case, please...