google-streetview-pano icon indicating copy to clipboard operation
google-streetview-pano copied to clipboard

Consider extending from google-map

Open ebidel opened this issue 10 years ago • 2 comments

A lot of its properties are re-implemented for this element.

ebidel avatar May 10 '14 20:05 ebidel

@ebidel I think these are the 3 repeated properties: apiKey version sensor. It also has a zoom property but it's zooming the panorama, and disableDefaultUI, which I think the map implements as well?

apiKey version sensor are passed through to the google-maps-api element. Which makes me wonder if both google-map and google-streetview-pano should extend from a more basic element like google-map-base or something. That may be preferable over inheriting from google-map itself since google-map has a lot of properties and methods that have nothing to do with streetview, for instance: latitude longitude showCenterMarker map mapType

robdodson avatar May 12 '14 01:05 robdodson

I'm meeting with Maps folks this week. I'll see what they think. There may be more shared in the future that they're aware of, but we're not using yet.

ebidel avatar May 12 '14 02:05 ebidel