google-streetview-pano icon indicating copy to clipboard operation
google-streetview-pano copied to clipboard

Published 20 hours ago • verified publisher icon GoogleWebComponents

Stop animation on detached

Open rbjarnason opened this issue 8 years ago • 3 comments

Otherwise the animation callbacks will get top level elements into endless attached/detached loops.

rbjarnason avatar Mar 23 '16 22:03 rbjarnason

Actually, this is still not enough to stop streetview pano events from spawning and destroying parent elements. I'm looking into this further.

streeviewmisbehavingmore

rbjarnason avatar Mar 23 '16 23:03 rbjarnason

Here is a screenshot showing what happens in the dom when the browser tab is active and this element creates and destroys yp-group in an endless loop.

browsertabwithfocus

rbjarnason avatar Mar 23 '16 23:03 rbjarnason

Good news! I was having some bower issues and was actually not running this latest code. This PR does fully resolve the problem so it should be good to go.

rbjarnason avatar Mar 23 '16 23:03 rbjarnason