google-map icon indicating copy to clipboard operation
google-map copied to clipboard

Polymer 3.0

Open emedvedev opened this issue 7 years ago • 8 comments

Updating to support the Polymer 3.0 preview. Took a few extra changes after modulizer to make it work. I guess it won't get merged, but hopefully other people who want to run the component on 3.0 will see this PR. :)

It's also published to npm under @em-polymer/google-map, so it should be fairly easy to install and use the fork for now, and then migrate once this repo comes alive. :)

emedvedev avatar Feb 13 '18 21:02 emedvedev

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address on your commit. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot. The email used to register you as an authorized contributor must be the email used for the Git commit.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

googlebot avatar Feb 13 '18 21:02 googlebot

I signed it!

emedvedev avatar Feb 13 '18 21:02 emedvedev

CLAs look good, thanks!

googlebot avatar Feb 13 '18 21:02 googlebot

Few months later... any updates on this?

sammymhowe avatar May 15 '18 15:05 sammymhowe

This pull request is out of date (converted with an older version of polymer-modulizer).

I converted with a more recent version (0.4) over at #421

dejan9393 avatar May 24 '18 02:05 dejan9393

Would love to see this PR get merged!

nstogner avatar Jul 10 '18 17:07 nstogner

sorry looks like there is another branch that passes all checks https://github.com/GoogleWebComponents/google-map/pull/443

elynch303 avatar Aug 14 '19 21:08 elynch303

google-map in webcomponents didn't provides GetPointAtDistance and GetIndexAtDistance. What way it can create?

foolunleong avatar Jan 29 '20 06:01 foolunleong