google-map icon indicating copy to clipboard operation
google-map copied to clipboard

Add map bounds to available data.

Open francescortiz opened this issue 7 years ago • 7 comments

I am integrating google-map with an elm project and at a certain point I needed to have the map bounds available without callbacks.

francescortiz avatar Sep 08 '17 12:09 francescortiz

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

googlebot avatar Sep 08 '17 12:09 googlebot

I signed it!

francescortiz avatar Sep 08 '17 16:09 francescortiz

CLAs look good, thanks!

googlebot avatar Sep 08 '17 16:09 googlebot

I added the option to disable fullscreen control.

francescortiz avatar Sep 10 '17 08:09 francescortiz

Added commit that fixes issues with Elm virtual DOM after removing the map and showing it again.

francescortiz avatar Sep 13 '17 12:09 francescortiz

Added commit that fixes issues with Elm virtual DOM after removing the map and showing it again.

can't help thinking the Elm stuff should go in a seperate PR with a full explanation of why it was necessary and the consequences for non-Em users.

But beyond that I really hope someone gets round to reviewing this as this is an important feaure

simonh1000 avatar Aug 18 '19 06:08 simonh1000

Added commit that fixes issues with Elm virtual DOM after removing the map and showing it again.

can't help thinking the Elm stuff should go in a seperate PR with a full explanation of why it was necessary and the consequences for non-Em users.

But beyond that I really hope someone gets round to reviewing this as this is an important feaure

The issue here is not related to Elm. Elm only made it surface. The situation is that markers can be added an removed to the DOM. The HTML DOM allows that and webcomponents honor that. The fix here is to check for the existence of the google.maps.Marker instance and not the existence of the google.maps.Map when we are binding/unbinding marker related events. I can open a new PR, but I thing the situation is simple enough.

francescortiz avatar Aug 19 '19 07:08 francescortiz