google-apis icon indicating copy to clipboard operation
google-apis copied to clipboard

fix: add debounce to computeUrl to remove angular2 multiple api error

Open MrChoclate opened this issue 8 years ago • 6 comments

fix #67

It fixes the issue on my angular2 project.

@ebidel is this what you meant?:

the loading code can probably use a debouncer

MrChoclate avatar Aug 26 '16 12:08 MrChoclate

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

googlebot avatar Aug 26 '16 12:08 googlebot

I signed it!

MrChoclate avatar Aug 26 '16 12:08 MrChoclate

CLAs look good, thanks!

googlebot avatar Aug 26 '16 12:08 googlebot

Thanks for the PR. I have some reservations about the approach. Namely, it will make all maps components 300ms slower. How short can you make the time before it no longer works?

ebidel avatar Aug 26 '16 22:08 ebidel

It seems that wait=0 remove the error. It is way far beyond my expertise to understand why. So someone should check that it is correct.

Did I correctly understand your review?

MrChoclate avatar Aug 27 '16 12:08 MrChoclate

My hypothesis is that Angular code is executed synchronously and is not letting the callback executed so that all the attributes of the Polymer element are properly set before the callback is executed.

Anyway, this PR won't slow anymore all maps components. But it will be great to have a comment explaining why it is necessary.

MrChoclate avatar Aug 27 '16 12:08 MrChoclate