web-stories-wp icon indicating copy to clipboard operation
web-stories-wp copied to clipboard

Use SVG sprites for icons

Open Swanand01 opened this issue 8 months ago • 15 comments

Summary

This PR adds support for using an svg sprite to render icons. The svg-sprite-loader webpack loader is used to generate the sprites.

User-facing changes

None.

Testing Instructions

This PR can be tested by following these steps:

  1. Inspect any svg icon in the plugin.
  2. You should see markup like this:
<svg viewBox="0 0 24 24" width="22px">
  <use xlink:href="#homeWithHeart"></use>
</svg>

Reviews

Does this PR have a security-related impact?

No.

Does this PR change what data or activity we track or use?

No.

Does this PR have a legal-related impact?

No.

Checklist

  • [x] This PR addresses an existing issue and I have linked this PR to it
  • [x] I have tested this code to the best of my abilities
  • [x] I have verified accessibility to the best of my abilities (docs)
  • [ ] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • [x] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • [x] I have added documentation where necessary
  • [x] I have added a matching Type: XYZ label to the PR

Fixes #13411

Swanand01 avatar Jun 19 '24 04:06 Swanand01