web-stories-wp icon indicating copy to clipboard operation
web-stories-wp copied to clipboard

TypeScript: Convert `@googleforcreators/output` to TypeScript

Open amovar18 opened this issue 2 years ago • 0 comments

Context

This PR aims to convert the @googleforcreators/output package from JavaScript to TypeScript.

Summary

This PR creates required types for @googleforcreators/output package and converts the JavaScript files to TypeScript file.

Relevant Technical Choices

To-do

  • [ ] Remove various comments regarding eslint disable and enable which have been placed since @googleforcreators/elements, @googleforcreators/masks, @googleforcreators/element-library and @googleforcreators/animation haven't yet been converted to TypeScript.
  • [ ] Convert Test cases to TypeScript.
  • [ ] Need to figure out amp-* tags types.

User-facing changes

Testing Instructions

  • [x] This is a non-user-facing change and requires no QA

Reviews

Does this PR have a security-related impact?

Does this PR change what data or activity we track or use?

Does this PR have a legal-related impact?

Checklist

  • [ ] This PR addresses an existing issue and I have linked this PR to it in ZenHub
  • [x] I have tested this code to the best of my abilities
  • [x] I have verified accessibility to the best of my abilities (docs)
  • [x] I have verified i18n and l10n (translation, right-to-left layout) to the best of my abilities
  • [x] This code is covered by automated tests (unit, integration, and/or e2e) to verify it works as intended (docs)
  • [x] I have added documentation where necessary
  • [x] I have added a matching Type: XYZ label to the PR

Fixes #12089

amovar18 avatar Sep 28 '22 08:09 amovar18