ts-runtime-checks icon indicating copy to clipboard operation
ts-runtime-checks copied to clipboard
verified publisher icon GoogleFeud

Fix build error for special characters

Open rmagur1203 opened this issue 1 year ago • 1 comments

#63

  • Use ElementAccessExpression when accessing properties.
  • When doing destructuring assignment, wrap the key in a StringLiteral.
  • Normalizes characters that cannot be used in identifier.

rmagur1203 avatar Aug 20 '24 16:08 rmagur1203

Thank you for the PR! It looks like you've changed the line endings of the file though, could you please use the line endings defined in the .prettierrc.json file? Also, could you please use the dev branch, because that's where changes go before they're published

GoogleFeud avatar Aug 24 '24 19:08 GoogleFeud

@rmagur1203 Are you still planning to make the edits required on this PR?

jerzygangi avatar Oct 07 '24 13:10 jerzygangi

In prettierrc, the end of line is set to crlf, but in reality it seems to be set to lf. Changed it to lf and modified it to merge into the dev branch.

rmagur1203 avatar Nov 11 '24 13:11 rmagur1203