skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

fix(helm): implement ordered cleanup for Helm releases based on dependency levels

Open BabisK opened this issue 8 months ago • 6 comments

Fixes: #9837 Related: #7284 Merge before/after: Dependent or prerequisite PRs

Description

Respect the dependency graph between helm releases during clean up. Levels of the graph are cleaned on reverse order compared to installation. Releases in the same level are cleaned up in reverse order too.

User facing changes (remove if N/A)

Before Releases are undeployed in the order they are mentioned in Config.

^CCleaning up...
release "postgres-operator" uninstalled
release "postgres" uninstalled

After Releases are undeployed in the reverse order they were deployed, respecting the dependsOn values.

^CCleaning up...
release "postgres" uninstalled
release "postgres-operator" uninstalled

BabisK avatar Jun 27 '25 18:06 BabisK

@idsulik would you mind reviewing this since you added this dependency support?

plumpy avatar Nov 05 '25 19:11 plumpy

@plumpy hi! Everything looks fine now

idsulik avatar Nov 15 '25 18:11 idsulik

Fixed the UTs, the --client had been removed.

BabisK avatar Nov 25 '25 19:11 BabisK

@BabisK hi! What changes should I review if you rewrote the commit?

idsulik avatar Nov 25 '25 19:11 idsulik

@idsulik You are right. I'm still learning the processes of this repo.

The change was the removal of --client in helm version in the unit test of this change. The expectation of this command had changed across all this test file causing the test to fail.

BabisK avatar Nov 25 '25 19:11 BabisK

@idsulik You are right. I'm still learning the processes of this repo.

It's a bad idea to rewrite commits when contributing to open source projects or just working with someone on the same project.

If you just fix tests and they work, there is no need to request additional review.

Last but not least - keep going!)

idsulik avatar Nov 25 '25 19:11 idsulik