skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

fix(tar): data race fix

Open idsulik opened this issue 1 year ago • 1 comments

Fixes: #9308

Description Found and fixed data race condition in tar.go

idsulik avatar Feb 10 '24 09:02 idsulik

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 63.54%. Comparing base (290280e) to head (c2109d5). Report is 1133 commits behind head on main.

:exclamation: Current head c2109d5 differs from pull request most recent head c391b0d. Consider uploading reports for the commit c391b0d to get more accurate results

Files Patch % Lines
pkg/skaffold/util/tar.go 63.63% 3 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9309      +/-   ##
==========================================
- Coverage   70.48%   63.54%   -6.94%     
==========================================
  Files         515      635     +120     
  Lines       23150    32804    +9654     
==========================================
+ Hits        16317    20846    +4529     
- Misses       5776    10349    +4573     
- Partials     1057     1609     +552     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Feb 10 '24 09:02 codecov[bot]

@ericzzzzzzz Hi! Should I do anything else or I just need to wait?

idsulik avatar Apr 13 '24 07:04 idsulik

Thank you for the fix!

ericzzzzzzz avatar Apr 15 '24 18:04 ericzzzzzzz

p.s. pushed an empty commit to restart the failed job

idsulik avatar Apr 16 '24 05:04 idsulik