skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

Data race in tar.go

Open idsulik opened this issue 1 year ago • 0 comments

Expected behavior

No data race

Actual behavior

WARNING: DATA RACE
Read at 0x00c0000b0040 by goroutine 469:
  archive/tar.(*regFileWriter).logicalRemaining()
      <autogenerated>:1 +0x38
  archive/tar.(*Writer).Flush()
      /usr/local/go/src/archive/tar/writer.go:53 +0x5c
  archive/tar.(*Writer).Close()
      /usr/local/go/src/archive/tar/writer.go:478 +0xa4
  github.com/GoogleContainerTools/skaffold/v2/pkg/skaffold/util.CreateTar.func1()
      /Users/main/Development/idsulik/skaffold/pkg/skaffold/util/tar.go:53 +0x34

Information

  • Skaffold version: v1.38.0-807-g6c5ca638a-dirty
  • Operating system: mac os
  • Installed via: built using source code

Steps to reproduce the behavior

  1. cd pkg/skaffold/util
  2. go test -race -count 5 ./

First seen here https://github.com/GoogleContainerTools/skaffold/actions/runs/7853592263/job/21433391917?pr=9307

idsulik avatar Feb 10 '24 09:02 idsulik