fix(docker): pass BUILDPLATFORM env when --platform argument is used
Fixes: #9284
Description I'm not sure if I fixed the bug correctly, as I couldn't reproduce the bug for myself
User facing changes (remove if N/A)
before: if you use --platform={platform} the BUILDPLATFORM argument was not passed to the docker
now: it'll pass BUILDPLATFORM
Codecov Report
Attention: 295 lines in your changes are missing coverage. Please review.
Comparison is base (
290280e) 70.48% compared to head (682fb31) 63.61%. Report is 1107 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #9291 +/- ##
==========================================
- Coverage 70.48% 63.61% -6.87%
==========================================
Files 515 635 +120
Lines 23150 32775 +9625
==========================================
+ Hits 16317 20851 +4534
- Misses 5776 10322 +4546
- Partials 1057 1602 +545
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@ericzzzzzzz Hi! Should I do anything else or I just need to wait?
The original has already been fixed. see https://github.com/GoogleContainerTools/skaffold/issues/9284#issuecomment-1927689782 . So I'm closing this one.