skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

fix(kaniko): delete kaniko pod on graceful shutdown

Open idsulik opened this issue 1 year ago • 1 comments

Fixes: #8800

Description Fixed kaniko pod delete in case of graceful shutdown

User facing changes Before: skaffold doesn't delete kaniko pod if build is interrupted with ctrl-c after creating the pod

After: skaffold triggers deletion of kaniko pod if build is interrupted with ctrl-c after creating the pod

idsulik avatar Jan 21 '24 10:01 idsulik

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 63.56%. Comparing base (290280e) to head (8612ece). Report is 1133 commits behind head on main.

:exclamation: Current head 8612ece differs from pull request most recent head e8c82e0. Consider uploading reports for the commit e8c82e0 to get more accurate results

Files Patch % Lines
pkg/skaffold/build/cluster/kaniko.go 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9270      +/-   ##
==========================================
- Coverage   70.48%   63.56%   -6.92%     
==========================================
  Files         515      634     +119     
  Lines       23150    32711    +9561     
==========================================
+ Hits        16317    20793    +4476     
- Misses       5776    10316    +4540     
- Partials     1057     1602     +545     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 31 '24 03:01 codecov[bot]

@ericzzzzzzz hi! Check please the PR, it's very important because all my colleagues have this issue which leads to 100500 undelete kaniko pods.

image

idsulik avatar Apr 14 '24 04:04 idsulik

Thanks for the fix! There's something wrong with integration tests, but it doesn't seems related to the change, I'm still investigating, after the issue resolved, I'll merge this change. Sorry for the delay.

ericzzzzzzz avatar Apr 15 '24 18:04 ericzzzzzzz