skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

fix: make EnvAPIClient and docker-cli have same behavior towards env DOCKE…

Open terloo opened this issue 2 years ago • 2 comments

Description

User will usually enable https when using docker-cli command line call remote docker-server.

But in skaffold, it will not enable TLS even user has env named DOCKER_TLS_VERIFY when get imageId from docker-server, that is different to behavior of docker-cli.

It cause a problem that people get a error Error response from daemon: Client sent an HTTP request to an HTTPS server. after they completed their docker-cli config and make useDockerCLI: true.

User facing changes (remove if N/A) When env DOCKER_TLS_VERIFY is not null, docker api client will enable TLS and read TLS file by order.

Follow-up Work (remove if N/A)

Maybe we should update the document?

terloo avatar Jul 09 '23 14:07 terloo

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Jul 09 '23 14:07 google-cla[bot]

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/