skaffold
skaffold copied to clipboard
Add an example for helm chart with multiple images
Shows how to override multiple images in a helm template
Description Documentation-only changes: Add a snippet showing how to override multiple images from skaffold-built artifacts. I was testing with this and thought an example in the doc would be useful. Thoughts?
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Thanks for the submission @filipenf! Currently you have updated:
docs/content/en/docs/pipeline-stages/deployers/helm.md
We have recently forked our docs into a docs
and a docs-v2
folder. Can you also update the
docs-v2/content/en/docs/pipeline-stages/deployers/helm.md
file with this change as well?
Additionally our repo has a unit test to enforce Conventional Commits. Can you ammend your commit message to add a prefix - docs:
eg:
docs: Add an example for helm chart with multiple images
Once these are resolved we can merge!
@aaron-prindle thanks for the info, I just checked the helm.md in the v2 path you mentioned and I noticed that it is missing a few of the sections from the original file. Would you also like me to match those or should I just add the new bits?
@filipenf just the new bits thanks! I believe the other differences are inherent to Skaffold v1 vs v2 (so they should be different)
@aaron-prindle I added just the new bits and updated the commit message, however I noticed that the whole ## Image Configuration
section is missing in the v2 doc. Is that expected?
@filipenf ah, I see now. Yes, if you wouldn't mind adding that section as well here that would be great. Thanks for the extra analysis here!
Codecov Report
Merging #7874 (aabee23) into main (290280e) will decrease coverage by
3.80%
. The diff coverage is53.94%
.
@@ Coverage Diff @@
## main #7874 +/- ##
==========================================
- Coverage 70.48% 66.67% -3.81%
==========================================
Files 515 593 +78
Lines 23150 28698 +5548
==========================================
+ Hits 16317 19135 +2818
- Misses 5776 8157 +2381
- Partials 1057 1406 +349
Impacted Files | Coverage Δ | |
---|---|---|
cmd/skaffold/app/cmd/credits/export.go | 0.00% <0.00%> (ø) |
|
cmd/skaffold/app/cmd/deploy.go | 40.90% <0.00%> (-12.94%) |
:arrow_down: |
cmd/skaffold/app/cmd/test.go | 44.44% <0.00%> (ø) |
|
cmd/skaffold/skaffold.go | 0.00% <0.00%> (ø) |
|
cmd/skaffold/app/cmd/inspect_tests.go | 62.50% <14.28%> (-1.14%) |
:arrow_down: |
cmd/skaffold/app/cmd/render.go | 35.48% <18.18%> (-5.90%) |
:arrow_down: |
cmd/skaffold/app/cmd/lsp.go | 28.12% <28.12%> (ø) |
|
cmd/skaffold/app/cmd/run.go | 64.28% <33.33%> (-9.63%) |
:arrow_down: |
cmd/skaffold/app/cmd/fix.go | 56.41% <37.50%> (-20.07%) |
:arrow_down: |
cmd/skaffold/app/cmd/verify.go | 41.17% <41.17%> (ø) |
|
... and 366 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
When using schema v3 artifactOverrides
does not exist, instead I've used setValueTemplates
as follow:
manifests:
helm:
releases:
- setValueTemplates:
firstContainerImage.repo: '{{.IMAGE_REPO}}'
firstContainerImage.tag: '{{.IMAGE_TAG}}'
secondContainerImage.repo: '{{.IMAGE_REPO2}}'
secondContainerImage.tag: '{{.IMAGE_TAG2}}'
...