skaffold
skaffold copied to clipboard
Fix Helm flags not working via skaffold #7047 (#1)
Fixes: #7047 Related: Relevant tracking issues, for context Merge before/after: Dependent or prerequisite PRs
Description
Update document
skaffold execute helm upgrade with flags
flags: upgrade: - '--history-max 3' a space in the flag leads to an error
no errors and all works as expected with '=' to replace a space here flags: upgrade: - '--history-max=3'
User facing changes (remove if N/A)
Follow-up Work (remove if N/A)
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).
View this failed invocation of the CLA check for more information.
For the most up to date status, view the checks section at the bottom of the pull request.
Thank you @nayang7 for your PR. Can you please
- move this change to integration/examples/ folder? The examples get copied over from the above folder.
- Please sign the Google CLA
Thanks Tejal
@nayang7 let us know if you need any more pointers?
Hi @tejal29, I'm with the Fidelity Investments OSPO. We're in the process of getting approvals to sign the CLA. Once that's done, we'll get @nayang7 added so the CLA check can clear.
Thank you @brianwarner . Looking forward to work with your team.
Don't hesitate to reach to us if you need anything.
@nayang7 Thank you for your contribution. Please sign the CLA so we can accept this contribution.
Hi @tejal29, we've gotten the approvals to create a Google Group, and will hopefully have signed the corporate CLA next week.
Will close this one since it didn't follow branch merge standard. @brianwarner @tejal29
The new PR https://github.com/GoogleContainerTools/skaffold/pull/7842
sounds good. Closing this PR