skaffold icon indicating copy to clipboard operation
skaffold copied to clipboard

refactor: remove v1 runner interfaces and simplify code

Open tejal29 opened this issue 2 years ago • 2 comments

Should merge after Beta release.

Simplifying skaffold codebase and moving all runner/v2 to runner. Similarly moving all runcontext/v2 to runcontext. This will remove all dead v1 related code on main

Summary of changes

git commit --amend
[rm_v1_runner b5c582c4b] remove v1 interfaces and simplify code
 Date: Tue Aug 2 18:05:09 2022 -0700
 49 files changed, 206 insertions(+), 235 deletions(-)
 rename pkg/skaffold/runner/{v2 => }/apply.go (99%)
 rename pkg/skaffold/runner/{v2 => }/cleanup.go (98%)
 rename pkg/skaffold/runner/{v2 => }/deploy.go (99%)
 rename pkg/skaffold/runner/{v2 => }/deploy_test.go (91%)
 rename pkg/skaffold/runner/{v2 => }/dev.go (99%)
 rename pkg/skaffold/runner/{v2 => }/dev_test.go (97%)
 rename pkg/skaffold/runner/{v2 => }/generate_pipeline.go (98%)
 rename pkg/skaffold/runner/{v2 => }/new.go (89%)
 rename pkg/skaffold/runner/{v2 => }/render.go (99%)
 rename pkg/skaffold/runner/runcontext/{v2 => }/context.go (99%)
 rename pkg/skaffold/runner/{v2 => }/runner_test.go (98%)
 rename pkg/skaffold/runner/{v2 => }/test.go (98%)
 delete mode 100644 pkg/skaffold/runner/v2/runner.go
 rename pkg/skaffold/runner/{v2 => }/verify.go (99%)

tejal29 avatar Aug 03 '22 01:08 tejal29

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot https://conventionalcommits.org/

Codecov Report

Merging #7724 (550dca1) into main (290280e) will decrease coverage by 3.85%. The diff coverage is 53.59%.

@@            Coverage Diff             @@
##             main    #7724      +/-   ##
==========================================
- Coverage   70.48%   66.62%   -3.86%     
==========================================
  Files         515      590      +75     
  Lines       23150    28457    +5307     
==========================================
+ Hits        16317    18960    +2643     
- Misses       5776     8106    +2330     
- Partials     1057     1391     +334     
Impacted Files Coverage Δ
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) :arrow_down:
cmd/skaffold/app/cmd/test.go 44.44% <0.00%> (ø)
cmd/skaffold/skaffold.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_tests.go 62.50% <14.28%> (-1.14%) :arrow_down:
cmd/skaffold/app/cmd/render.go 35.48% <18.18%> (-5.90%) :arrow_down:
cmd/skaffold/app/cmd/lsp.go 28.12% <28.12%> (ø)
cmd/skaffold/app/cmd/run.go 64.28% <33.33%> (-9.63%) :arrow_down:
cmd/skaffold/app/cmd/fix.go 56.41% <37.50%> (-20.07%) :arrow_down:
cmd/skaffold/app/cmd/verify.go 41.17% <41.17%> (ø)
... and 360 more

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

codecov[bot] avatar Aug 03 '22 01:08 codecov[bot]