Skaffold should rewrite imagePullPolicy when using a local cluster

Open briandealwis opened this issue 4 years ago • 3 comments

When using a local cluster like minikube, where the built images are loaded directly into the cluster's container runtime, a user will encounter see a deployment failure should they specify an imagePullPolicy: Always. Skaffold should transform the manifests and either remove such pull-policies or possibly transform them to imagePullPolicy: Never.

Jan 05 '22 15:01 briandealwis

I think it make complete sense. I would be ok to transform the manifests in memory since skaffold already parses these.

Jan 10 '22 19:01 tejal29

Fully agree with the proposal.

A workaround for me is to use imagePullPolicy: IfNotPresent, since I use immutable image tags. (In which case imagePullPolicy can also be omitted, since IfNotPresent is default.)

Jun 19 '24 06:06 th0ger

Hi @briandealwis @tejal29,

I’ve submitted PR #9495 for this feature. Your feedback would be greatly appreciated. Thanks!

Aug 12 '24 11:08 lucasrod16