kpt-config-sync
kpt-config-sync copied to clipboard
Remove the logic for setting the nested `protocol` field in k8s objects containing an array of `ports`.
The logic was added in March 2021 as a workaround for a known k8s issue, which causes getting the declared fields for k8s objects containing an array of ports to fail. The fixes to the k8s issue have been merged into k8s 1.20 and 1.21:
-
https://github.com/kubernetes/kubernetes/pull/96317 (merged in 1.20)
-
https://github.com/kubernetes/kubernetes/pull/98576 (merged in 1.21).
k8s 1.21 is no longer supported on GKE and Anthos:
-
GKE release schedule: https://cloud.google.com/kubernetes-engine/docs/release-schedule
-
Anthos version and upgrade support: https://cloud.google.com/anthos/docs/version-and-upgrade-support
Therefore, we can remove the logic and related unit tests. We can keep the e2e test to make sure this change does not break things.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from haiyanmeng. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@haiyanmeng: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| kpt-config-sync-presubmit-e2e-multi-repo-test-group1 | 2dd18dea39ae97556d3ace01bebce006d15740d8 | link | true | /test kpt-config-sync-presubmit-e2e-multi-repo-test-group1 |
| kpt-config-sync-presubmit-e2e-multi-repo-test-group2 | 2dd18dea39ae97556d3ace01bebce006d15740d8 | link | true | /test kpt-config-sync-presubmit-e2e-multi-repo-test-group2 |
| kpt-config-sync-presubmit-e2e-multi-repo-test-group3 | 2dd18dea39ae97556d3ace01bebce006d15740d8 | link | true | /test kpt-config-sync-presubmit-e2e-multi-repo-test-group3 |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
/hold
Please ignore my message. I'm just testing prow settings in the repo.
Is this WIP? If it is consider closing the PR and keeping the private branch or converting to draft.