kpt-config-sync icon indicating copy to clipboard operation
kpt-config-sync copied to clipboard

add support for shared kind clusters

Open sdowell opened this issue 3 years ago • 10 comments

this change adds support to run kind clusters with a shared test environment. This can be run either sequentially or in parallel. The clusters are created at the beginning of the suite, reused between tests, and deleted at the end of the suite.

This is intended to:

  • Speed up the presubmit jobs by reducing time spent creating kind clusters
  • Make it easier to run tests with a shared test environment (e.g. reproducing test cleanup issues locally)
  • Shift-left the shared environment testing to the presubmits so issues with test cleanup can be found before reaching periodics

It occurred to me while implementing this that we could use the same approach for the GKE testing, where we treat a set of GKE clusters as a shared pool in the tests. This approach could potentially replace the test group configuration, which would simplify the prow configuration. For now this does not make any changes to how GKE shared tests are run.

sdowell avatar Oct 21 '22 23:10 sdowell

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

google-oss-prow[bot] avatar Oct 21 '22 23:10 google-oss-prow[bot]

/cc @karlkfi /cc @nan-yu /test all

sdowell avatar Oct 21 '22 23:10 sdowell

/test all

sdowell avatar Oct 22 '22 23:10 sdowell

/test all

sdowell avatar Oct 24 '22 17:10 sdowell

/test all

sdowell avatar Oct 24 '22 18:10 sdowell

Pulled out the kubeconfig changes as a separate PR: https://github.com/GoogleContainerTools/kpt-config-sync/pull/238

sdowell avatar Oct 24 '22 22:10 sdowell

/test all

sdowell avatar Oct 25 '22 02:10 sdowell

/retest

sdowell avatar Oct 26 '22 03:10 sdowell

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nan-yu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Oct 27 '22 21:10 google-oss-prow[bot]

/retest

sdowell avatar Oct 27 '22 23:10 sdowell