kpt-config-sync icon indicating copy to clipboard operation
kpt-config-sync copied to clipboard

[WIP] Add watch filtering by package-id label (obsolete)

Open karlkfi opened this issue 1 year ago • 2 comments

go/config-sync-watch-filter

Dependencies:

  • https://github.com/GoogleContainerTools/kpt-config-sync/pull/1199
  • https://github.com/GoogleContainerTools/kpt-config-sync/pull/1204
  • https://github.com/GoogleContainerTools/kpt-config-sync/pull/1241
  • https://github.com/GoogleContainerTools/kpt-config-sync/pull/1244

TODO:

  • Extract SyncStatusUpdater changes
  • Extract conflict handler changes
  • Finalize design approval (some open questions about label naming)

karlkfi avatar May 30 '24 00:05 karlkfi

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from karlkfi. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar May 30 '24 00:05 google-oss-prow[bot]

This PR is replaced by https://github.com/GoogleContainerTools/kpt-config-sync/pull/1301, which has less tech debt in it. But I'm going to keep this one open and blocked for a bit so I can mine it for refactoring to do after watch filtering merges.

karlkfi avatar Jul 04 '24 01:07 karlkfi