kpt-config-sync
kpt-config-sync copied to clipboard
test: add test coverage for missing permissions
There are multiple issues with missing permission, though they all share the same KNV2004 error code. This commit adds test coverage for the following scenarios:
- A GSA doesn't exist when using gcpserviceaccount
- A GSA exists, but it is not impersonated with a KSA.
- A GSA exists and is impersonated, but it doesn't have reader permission.
- A WI+KSA doesn't have reader permission.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please ask for approval from nan-yu. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
I accidentally pushed from the wrong fork branch. I'll push a new patch after addressing these comments.
@nan-yu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| kpt-config-sync-presubmit-e2e-multi-repo-test-group1 | c900b866692aa1f7b39a19d1e55c9e4aa44a1000 | link | true | /test kpt-config-sync-presubmit-e2e-multi-repo-test-group1 |
| kpt-config-sync-presubmit-e2e-multi-repo-test-group2 | c900b866692aa1f7b39a19d1e55c9e4aa44a1000 | link | true | /test kpt-config-sync-presubmit-e2e-multi-repo-test-group2 |
| kpt-config-sync-presubmit-e2e-multi-repo-test-group3 | c900b866692aa1f7b39a19d1e55c9e4aa44a1000 | link | true | /test kpt-config-sync-presubmit-e2e-multi-repo-test-group3 |
| kpt-config-sync-presubmit | c900b866692aa1f7b39a19d1e55c9e4aa44a1000 | link | true | /test kpt-config-sync-presubmit |
| kpt-config-sync-terraform-presubmit | c900b866692aa1f7b39a19d1e55c9e4aa44a1000 | link | true | /test kpt-config-sync-terraform-presubmit |
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.