kpt-config-sync icon indicating copy to clipboard operation
kpt-config-sync copied to clipboard

[WIP] Disable the CS admission webhook by default

Open haiyanmeng opened this issue 3 years ago • 16 comments

/hold

haiyanmeng avatar Sep 15 '22 02:09 haiyanmeng

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haiyanmeng

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

google-oss-prow[bot] avatar Sep 15 '22 02:09 google-oss-prow[bot]

/retest

haiyanmeng avatar Sep 15 '22 15:09 haiyanmeng

/retest

haiyanmeng avatar Sep 15 '22 15:09 haiyanmeng

quick nit - consider using draft PRs instead of a tag [WIP]

mikebz avatar Sep 15 '22 17:09 mikebz

quick nit - consider using draft PRs instead of a tag [WIP]

Thanks for pointing this out. I didn't even know you could do that. I just converted this PR into a draft PR.

haiyanmeng avatar Sep 15 '22 19:09 haiyanmeng

/retest

haiyanmeng avatar Sep 15 '22 23:09 haiyanmeng

/retest

haiyanmeng avatar Sep 19 '22 13:09 haiyanmeng

/test all

haiyanmeng avatar Sep 19 '22 13:09 haiyanmeng

/test all

haiyanmeng avatar Sep 19 '22 14:09 haiyanmeng

/test all

haiyanmeng avatar Sep 19 '22 15:09 haiyanmeng

/retest

haiyanmeng avatar Sep 19 '22 16:09 haiyanmeng

/test all

haiyanmeng avatar Sep 19 '22 17:09 haiyanmeng

/test all

haiyanmeng avatar Sep 19 '22 23:09 haiyanmeng

/retest

haiyanmeng avatar Sep 19 '22 23:09 haiyanmeng

/retest

haiyanmeng avatar Sep 20 '22 00:09 haiyanmeng

@haiyanmeng: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
kpt-config-sync-presubmit-e2e-multi-repo-test-group1 984b9cc69708a8495bd6ceb3bc7bfd7c09a15997 link true /test kpt-config-sync-presubmit-e2e-multi-repo-test-group1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

google-oss-prow[bot] avatar Sep 20 '22 00:09 google-oss-prow[bot]

is this PR still relevant?

mikebz avatar Apr 19 '23 15:04 mikebz

is this still relevant? Should we close it?

mikebz avatar Aug 21 '23 13:08 mikebz