GoogleContainerTools
The `--log-timestamp=false` option does not properly pass down `TextFormatter` into `logrus.TextFormatter`
Actual behavior
When passing in --log-timestamp=false with either --log-format=text|color set, timestamps still get logged.
Expected behavior No timestamps should get logged
To Reproduce Steps to reproduce the behavior:
- Pass in
--log-timestamp=falseand--log-format=textand notice timestamps still get logged.
Additional Information
- Kaniko Image v1.23.1
Triage Notes for the Maintainers
The culprit appears to be here: https://github.com/GoogleContainerTools/kaniko/blob/6bea4df3afb81106f31ebae979c26b64b5e800fb/pkg/logging/logging.go#L50-L59
This code should be utilizing the DisableTimestamp field instead of the FullTimestamp field in the logrus text formatter. See below:
https://github.com/sirupsen/logrus/blob/dd1b4c2e81afc5c255f216a722b012ed26be57df/text_formatter.go#L48-L50
| Description | Yes/No |
|---|---|
| Please check if this a new feature you are proposing |
|
| Please check if the build works in docker but not in kaniko |
|
Please check if this error is seen when you use --cache flag |
|
| Please check if your dockerfile is a multistage dockerfile |
|
Was the closing of this PR due to something in particular?
I felt my solution was too simplistic since perhaps the bug has ventured into "it's a feature now" territory.