kaniko icon indicating copy to clipboard operation
kaniko copied to clipboard

Use filename in cache key to prevent collisions under rename

Open SJrX opened this issue 8 months ago • 0 comments

Fixes #2241 #1678

Description

Issues #2241 #1678 both point to cases where renames can point to incorrect images being used with caching. This commit adds the path of the file (relative to the build context to the hash).

A different approach would be to change the underlying function in CacheHasher to include the name (and maybe file size), this was avoided for two reasons:

  1. It was unclear whether this would change or break the computed digests outside the context of caching.
  2. The CacheHasher does not know the prefix to strip in the filename to compute the hash.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [x] Includes unit tests
  • [ ] Adds integration tests if needed.

See the contribution guide for more details.

Reviewer Notes

  • [ ] The code flow looks good.
  • [ ] Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

Examples of user facing changes:
- kaniko adds a new flag `--registry-repo` to override registry

SJrX avatar Jun 16 '24 20:06 SJrX