kaniko icon indicating copy to clipboard operation
kaniko copied to clipboard

docs: add documentation for the --destination flag

Open nils-van-zuijlen opened this issue 1 year ago • 4 comments

Related to #217, #733

Description

Add documentation for the --destination flag to the readme.

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [x] Includes unit tests (Not needed for documentation?)
  • [x] Adds integration tests if needed. (Not needed)

See the contribution guide for more details.

Reviewer Notes

  • [ ] The code flow looks good.
  • [ ] Unit tests and or integration tests added.

nils-van-zuijlen avatar Mar 04 '24 15:03 nils-van-zuijlen

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Mar 04 '24 15:03 google-cla[bot]

I unfortunately am not able to sign the CLA because I do not want a Google account, but I hereby set this commit in the public domain. Feel free to take its content in another MR by yourself, see ya!

nils-van-zuijlen avatar Mar 04 '24 16:03 nils-van-zuijlen

I unfortunately am not able to sign the CLA because I do not want a Google account, but I hereby set this commit in the public domain. Feel free to take its content in another MR by yourself, see ya!

Thanks @nils-van-zuijlen for this PR - would you mind trying signing the CLA not via corporate contributor but via individual contributor? In that way you might not need to opt for the way to have a google account.

JeromeJu avatar Mar 28 '24 17:03 JeromeJu

Hi @JeromeJu I reopened this in #3274, since Nils put the changes into the public domain. Can you PTAL there & close this PR if #3274 looks good? Thanks 😁

Thanks Nils for the change, I just bumped into this.

dchaley avatar Aug 02 '24 06:08 dchaley