kaniko icon indicating copy to clipboard operation
kaniko copied to clipboard

feat: add --skip-snapshot arg which skips all build snapshots

Open Owez opened this issue 2 years ago • 1 comments

Fixes #1615

Description

This PR adds a new --skip-snapshot argument which skips running any snapshots at all. Right now people run --single-snapshot for performance reasons, but an edge case is not taking any snapshots at all.

Two asterisks to this contrib:

  • I don't know much Go so I'm not sure where/how to add unit tests sorry.
  • I had a look through build() and I believe snapshots/cache are uploaded as and when rather than having any further processing, so not having any snapshots should be alright?

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you review them:

  • [ ] Includes unit tests
  • [ ] Adds integration tests if needed.

Reviewer Notes

  • [ ] The code flow looks good.
  • [ ] Unit tests and or integration tests added.

Release Notes

Describe any changes here so maintainer can include it in the release notes, or delete this block.

- kaniko adds a new --skip-snapshot argument which skips taking any snapshots

Owez avatar Dec 08 '23 13:12 Owez

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

google-cla[bot] avatar Dec 08 '23 13:12 google-cla[bot]